[PEPr] Comment on Text::Text_CAPTCHA_Driver_Numeral

From: Date: Mon, 16 Oct 2006 23:23:41 +0000
Subject: [PEPr] Comment on Text::Text_CAPTCHA_Driver_Numeral
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-44583@lists.php.net to get a copy of this message
Justin Patrin (http://pear.php.net/user/justinpatrin) has commented on the proposal for Text::Text_CAPTCHA_Driver_Numeral. Comment: I still don't understand why you're making recursive calls. As Lorenzo said, just swap the 2 numbers. Much simpler. There's no reason for this to be recursive. if ($this->firstNumber < $this->secondNumber) { $tmp = $this->getFirstNumber(); $this->setFirstNumber($this->getSecondNumber()); $this->setSecondNumber($tmp); } Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=451 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#44583) next »