[PEPr] Comment on RFC::Constant_Contact

From: Date: Thu, 11 Jan 2007 06:02:07 +0000
Subject: [PEPr] Comment on RFC::Constant_Contact
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-45474@lists.php.net to get a copy of this message
Adam Harvey (http://pear.php.net/user/aharvey) has commented on the proposal for RFC::Constant_Contact. Comment: A few immediate thoughts for you: - RFC is probably the wrong category for the proposal; perhaps Mail or Web Services would be better. (I'd probably lean towards Web Services myself.) - Given the above, the class name would need to be changed to something like Mail_ConstantContact or Services_ConstantContact. - Instead of depending on libcurl, perhaps it might be better to look at using HTTP_Request, which doesn't require an external library. - It looks like the category, user name and password aren't run through urlencode before being submitted at the moment. - Before this gets to a vote, you'll need to review the PEAR coding standards for matters such as indenting -- the CS requires 4 spaces per indent level with no tab characters. Having said all the above, certainly don't let me discourage you from continuing, as this looks like it would be a useful addition to PEAR. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=471 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#45474) next »