[PEPr] Comment on RFC::Constant_Contact

From: Date: Thu, 11 Jan 2007 06:39:44 +0000
Subject: [PEPr] Comment on RFC::Constant_Contact
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-45475@lists.php.net to get a copy of this message
Christian Weiske (http://pear.php.net/user/cweiske) has commented on the proposal for RFC::Constant_Contact. Comment: - Call the package Services_ConstantContact. Currently it looks as if it is a package called "Contact" of the "Constant" category. - The extension check has to be done when instantiating the class, not without any reason. Also using "exit" does not allow the programmer to handle this error in code. Throwing a PEAR_Exception would be best, or simply depend on it in package.xml - Don't use tabs but spaces (see PEAR Coding Standards in the manual, and the PHP_CodeSniffer package that checks your code automatically) - You don't urlencode username and password. - Please add parameter descriptions for methods like addMember - I don't know what "postCode" is. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=471 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#45475) next »