[PEPr] +1 for HTTP::HTTP_FloodControl
| From: | Christian Weiske | Date: | Mon, 12 Mar 2007 17:23:36 +0000 |
| Subject: | [PEPr] +1 for HTTP::HTTP_FloodControl | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-45871@lists.php.net to get a copy of this message | ||
Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the proposal for
HTTP::HTTP_FloodControl.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=476
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=476&handle=cweiske
This vote is conditional. The condition is:
Nice package.
Next time, please provide .phps files for your sources.
- Make your private variables public unless you want to explicitely forbid using them in derived
classes.
- Always add a space between catch and the opening brace.
- The constructor docblock has a typo in HTTP_FloodControl_Container.
- set() in the file container has a typo in the exception text
- When throwing an exception based on a PEAR_Error, also pass the error code as second parameter to
the exception constructor.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net