Re: [PEPr] +1 for HTTP::HTTP_FloodControl

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Actually, you don't want to make your private variables public if you want descendant classes to use them. Instead you want to make them "protected". Also, if you're using PEAR_Exception it'll take a PEAR_Error object as a single parameter and suck in both the message and code automagically. - --Joe On Mar 12, 2007, at 10:23 AM, Christian Weiske wrote:

Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the proposal for HTTP::HTTP_FloodControl. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=476 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=476&handle=cweiske This vote is conditional. The condition is: Nice package. Next time, please provide .phps files for your sources. - Make your private variables public unless you want to explicitely forbid using them in derived classes. - Always add a space between catch and the opening brace. - The constructor docblock has a typo in HTTP_FloodControl_Container. - set() in the file container has a typo in the exception text - When throwing an exception based on a PEAR_Error, also pass the error code as second parameter to the exception constructor. --Sent by PEPr, the automatic proposal system at http://pear.php.net --PEAR Development Mailing List (http://pear.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFF9Y3Hh0MUGpYY9OQRAn5HAKC6IYwK8MDeVG9R+Q9vQTACrb+oUACfSQ2R YufmE3u+SgMHrHMU0C4xRRI= =ar15 -----END PGP SIGNATURE-----