Re: Patch Interface
| From: | David Coallier | Date: | Tue, 13 Mar 2007 20:44:07 +0000 |
| Subject: | Re: Patch Interface | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-45892@lists.php.net to get a copy of this message | ||
well it should really just check the mimetype.. who really cares about
diff, patch, php, txt, just get the content and no eval :P and also
store it at the good place and display it at content-type plain-text.
On 3/13/07, Gregory Beaver <greg@chiaraquartet.net> wrote:
Lorenzo Alberton wrote: Mike Willbanks wrote:-- David Coallier, Founder & Software Architect, Agora Production (http://agoraproduction.com) 51.42.06.70.18The patch name must be shorter than 40 characters and it must only contain alphanumeric characters or hyphens. For instance, the dot "." is invalid. HTH Hi, This is a good point, the patch name should allow . as well. Anyone feel like opening a bug? :) Otherwise, the patch tracker only accepts files with extension ".diff" or ".patch", I'm wondering if it should also accept ".txt"? Greg -- PEAR Development Mailing List (http://pear.php.net/) To unsubscribe, visit: http://www.php.net/unsub.phpOn the PEAR web site, how is one supposed to add a patch to a previous bug? For instance: Entering in a patch name doesn't seem to take any type of names aka: patch name or 123_patch.diff or anything else without returning an invalid patch name.