Re: Patch Interface

From:	Lorenzo Alberton	Date:	Tue, 13 Mar 2007 21:19:12 +0000
Subject:	Re: Patch Interface
References:	1 2 3	Groups:	php.pear.dev
Request:	Send a blank email to pear-dev+get-45893@lists.php.net to get a copy of this message

Gregory Beaver wrote:

The patch name must be shorter than 40 characters and it must only contain alphanumeric characters or hyphens. For instance, the dot "." is invalid.
This is a good point, the patch name should allow . as well. Anyone feel like opening a bug? :)

bug report and patches: http://pear.php.net/bugs/bug.php?id=10357&edit=1

Otherwise, the patch tracker only accepts files with extension ".diff" or ".patch", I'm wondering if it should also accept ".txt"?

as David said, a mimetype check would be the best option. HTH Cheers, -- Lorenzo Alberton http://pear.php.net/user/quipo ___________________________________________________________________ Quipo Free Internet - 2 email, 150 Mb di spazio web e molto di più. ADSL, Hardware & Software Online Store