Re: Re: New Package: Structures_DataGrid_DataSource for PDO

Sorry for the delay. Attached is a link to the code. That is a temporary link. This is my first time trying to code to the PEAR standards. I'm sure I'm missing some things. In fact, the delay was because I wanted to put in some comments. If you want to make this a package, give me another revision to fix the method block format and other little things before you spend too much time reviewing it. I haven't had a chance to look at the road map yet. I would like to help contribute over the long term. What is the next step? http://usa.trac-king.com/PDO.phps Dave On 4/18/07, Olivier Guilyardi <ojaiml@nerim.net> wrote:

Hi Mark and David, Mark Wiesemann wrote: David Wilson wrote:

My first email to the list here. I wrote a Structures_DataGrid_DataSource for PDO. It's probably 80% complete (with the 20% being some error handling and commenting).

There appears to be an old open feature request about this very topic: http://pear.php.net/bugs/bug.php?id=5076

I'm willing to finish it for including in PEAR. I emailed Olivier Guilyardi, but received no reply.

Sorry for the slow answer. I was too busy. Anyway, I'm the co-lead on the Structures_DataGrid (SDG) package and can help you, too. Indeed In general, new drivers for SDG are accepted (or, unlikely, rejected) through the normal PEAR PEPr process (details can be found in the PEAR manual). In this special case it is a little bit different because we're planning to release a new DataSource driver that combines the access to databases via PEAR::DB, PEAR::MDB2 and via PDO. This is also mentioned in our TODO file (available in the CVS repository). There is no code yet, and so your contribution would maybe be a good start. Agreed There's already much code replicated in the MDB2 and DBQuery drivers. We don't want to replicate some more in a new PDO driver. Our idea is to create a new SQLQuery driver that would supersede those drivers. SQLQuery would accept something like a "backend" option for specifying whether to use DB, MDB2, PDO, etc... for accessing the database. If you feel like helping us on this, you may want to try and work on SQLQuery, by merging the MDB2, DBQuery and your new driver. In the meantime you may want attach your new PDO driver to request #5076 (see link above), so that we don't lose it and possibly reuse some parts of it to create SQLQuery. I would suggest that we discuss the details via email. Please send me your code and CC Olivier Guilyardi. I think request #5076 is also a good place to discuss this issue. Regards, -- Olivier