Re: Re: New Package: Structures_DataGrid_DataSource for PDO
| From: | David Wilson | Date: | Sat, 21 Apr 2007 21:03:43 +0000 |
| Subject: | Re: Re: New Package: Structures_DataGrid_DataSource for PDO | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-46358@lists.php.net to get a copy of this message | ||
It looks like it would be easy to change the one I sent to match that
MDB2 methods.
Also, I like the idea of SQLQuery driver. I notice the MDB2 allows
either an instance or a dsn. I recommend that in the SQLQuery driver
it only allows for providing the object. Requiring the SQLQuery to
handle all the exceptions that may arrise from trying to connect to
the DB is more code than the driver should have to carry around.
Dave
On 4/21/07, Mark Wiesemann <wiesemann@php.net> wrote:
David Wilson wrote: Thanks I'll take a look at the other drivers. I have gotten a working implementation from another developer via email that is based on the MDB2 driver. I'll review it tomorrow and will sent an email to you and Olivier after that. Can you send me the sample scripts that failed? The described problem was my stupid fault, just ignore me please. ;-) Also, why the '&' here? Don't you want to create a new instance of the object?I create a new instance. The cited line is the common usage of SDG (and other classes) with PHP 4. It does not make much sense with PDO (which requires PHP 5), but it doesn't hurt to use it also here. Regards, Mark -- http://www.markwiesemann.eu$datagrid =& new Structures_DataGrid();