Re: PHP_CodeSniffer as part of the pepr proposal process

Hi, Greg Sherwood wrote: > Gregory Beaver wrote: >> I would be interested in investigating setting up codesniffer as a cron >> job for checking PEPr proposals. I'm assuming it would time out if used >> to check a large proposal. Have you tried it on something vast like >> phpDocumentor? >> > I just got a new version of phpDocumentor from PEAR, but all the > newlines are /r/n, which causes a significant amount of errors, That > might be an issue in itself for PEAR. > > I'll get rid of those errors and give it a run when I get time. First > impressions are that PHP_CodeSniffer doesn't like some of the code, so > I'll look into why and fix any errors I find. Running PHP_CodeSniffer on phpDocumentor might not be a good idea, as there are many CS violations like wrong placed or missing curly braces, never-ending lines (*g*), wrong file extensions etc. (No offense against the phpDocumentor people, this might be an historial issue because the package wasn't born in PEAR.) Testing it on another big package like MDB2 might be more reasonable because it should output better results, and because even package with sizes like on MDB2 are very rarely proposed (IIRC never yet). Regards, Mark -- http://www.markwiesemann.eu