Re: PHP_Compat 1.6alpha
| From: | Arpad Ray | Date: | Sun, 20 May 2007 10:52:25 +0000 |
| Subject: | Re: PHP_Compat 1.6alpha | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-46824@lists.php.net to get a copy of this message | ||
Daniel O'Connor wrote:
I'm completely unfamiliar with how you've done it all along, but it seems a little bit scary to rely on a global variable defined in another file - would it be safer to shift this to a method like fetchDefinedComponents() that returns an array of components? I can see the potential for some poor bugger out in userland picking $components as a variable name; and having PHP compat "secretly" change it...Actually $components is not a global variable, because it's only included inside a function. This could only ever affect a user if they included Components.php directly, which is pointless. Thanks for taking a look though, Arpad