[PEPr] +1 for PHP::PHP_GenDocBlock
| From: | Mark Wiesemann | Date: | Sun, 20 May 2007 12:12:25 +0000 |
| Subject: | [PEPr] +1 for PHP::PHP_GenDocBlock | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-46831@lists.php.net to get a copy of this message | ||
Mark Wiesemann (http://pear.php.net/user/wiesemann) has voted +1 on the proposal for
PHP::PHP_GenDocBlock.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=481
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=481&handle=wiesemann
This vote is conditional. The condition is:
(comments based on the gendocblock.0.3.tgz file)
- linebreak between "class" and "{" is still missing
- why is GenDocBlockTest.php in the PHP/ directory and not in the tests/ directory?
- to be honest, the run() method is unreadable:
* some people already complained about the and's and or's
* the comments after the lines "hide" the and's and or's IMHO
=> I would recommend to put the comment into separate lines and
to remove the and's and or's
- the "@" error suppression calls are still there, but not needed
(they can make debugging very complicated)
- comments for run() are also valid for e.g. alignTags(); instead of
---
$this->tagPadding = max(array_map('strlen', $tags)); // finds out the length of the
longest tag
---
I would recommend to use
---
// finds out the length of the longest tag
$this->tagPadding = max(array_map('strlen', $tags));
---
--
Sent by PEPr, the automatic proposal system at http://pear.php.net