Re: Re: Conditional package dependencies?
| From: | Mark Wiesemann | Date: | Mon, 11 Jun 2007 19:38:54 +0000 |
| Subject: | Re: Re: Conditional package dependencies? | ||
| References: | 1 2 3 4 5 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-47016@lists.php.net to get a copy of this message | ||
Hi,
thanks for the ideas and suggestions.
Olivier Guilyardi wrote:
I see your point... Bad thing indeed. A such flag is bloat-ish IMO. I feel like there might other similar issues, that might lead us to write obfuscated code. I'm starting to wonder if it wouldn't be better to simply mark SQL_DS_DBQuery and SQL_DS_MDB2Query as superseded by SDG_DS_SQLQuery on their respective homepages and in the manual, the later being PHP5 only. Anyway all drivers must be manually installed, they are subpackages. So the fact that SDG depends on a PHP5 driver shouldn't create installation problems on PHP4.I agree with Olivier here. Having a conditional dependency would have been nice. Greg's workaround sounded nice at first, but has too many things that need to be taken care of, and especially things like error handling might get really ugly then. Therefore, marking the DBQuery and MDB2 driver as superseded by the SQLQuery driver, putting notes into the manual, and putting a big warning into the changelog seems to be the best solution. We could also consider to make a special error message for this BC break in the Structures_DataGrid class, but that's something that we will discuss internally. Regards, Mark -- http://www.markwiesemann.eu