Re: Re: Conditional package dependencies?

Hi Mark, Mark Wiesemann wrote: > thanks for the ideas and suggestions. > Olivier Guilyardi wrote: >> I'm starting to wonder if it wouldn't be better to simply mark >> SQL_DS_DBQuery >> and SQL_DS_MDB2Query as superseded by SDG_DS_SQLQuery on their respective >> homepages and in the manual, the later being PHP5 only. >> >> Anyway all drivers must be manually installed, they are subpackages. >> So the fact >> that SDG depends on a PHP5 driver shouldn't create installation >> problems on PHP4. > > I agree with Olivier here. Having a conditional dependency would have > been nice. Greg's workaround sounded nice at first, but has too many > things that need to be taken care of, and especially things like error > handling might get really ugly then. Agreed > Therefore, marking the DBQuery and MDB2 driver as superseded by the > SQLQuery driver, putting notes into the manual, and putting a big > warning into the changelog seems to be the best solution. We could also > consider to make a special error message for this BC break in the > Structures_DataGrid class, but that's something that we will discuss > internally. Actually, there should be no BC break... We could just do maintenance releases for SQL_DS_DBQuery and SQL_DS_MDB2, and asking for people to switch to SQL_DS_SQLQuery. This is possible because of this important choice that we made in the past not to install any driver automatically. Oh, well... there might be problem withing SDG::_detectSourceType()... Let's discuss that offline. Thanks everyone -- Olivier