[PEPr] Comment on Encryption::Crypt_HMAC2
| From: | Till Klampaeckel | Date: | Thu, 21 Jun 2007 17:01:32 +0000 |
| Subject: | [PEPr] Comment on Encryption::Crypt_HMAC2 | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-47099@lists.php.net to get a copy of this message | ||
Till Klampaeckel (http://pear.php.net/user/till) has commented on the proposal for
Encryption::Crypt_HMAC2.
Comment:
Looks good, where do I buy? :-)
CS:
* I may be old-fashioned, but don't require inside classes (0)
* think about private vs. protected in respect to extending later on
General question, don't you want to probe for extensions (1) in the
constructor and set a couple internal flags based on that? You could
probably save yourself the hassle function_exists() later on. But that's
just a thought.
0, http://pooteeweet.org/blog/538
1, http://php.net/extension_loaded
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=495
--
Sent by PEPr, the automatic proposal system at http://pear.php.net