[PEPr] Comment on Web Services::Services_Yadis
| From: | P�draic Brady | Date: | Thu, 12 Jul 2007 22:22:04 +0000 |
| Subject: | [PEPr] Comment on Web Services::Services_Yadis | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-47441@lists.php.net to get a copy of this message | ||
Pádraic Brady (http://pear.php.net/user/padraic) has commented on the proposal for Web
Services::Services_Yadis.
Comment:
Hi Christian,
I'll get to your comments during tomorrow. All seem valuable, so I'll look
into each when I have time to do it properly. On two of the points;
I underscore all private and protected methods and properties. It's not
necessary per se but I find it a subtle hint that makes my reading at least
that bit easier.
On the XRD namespaces. I'll double check, but I believe the XRD syntax
requires the definitions as a reservation of sorts. Note this is broken by
allowing users to override such reserved namespaces (as you commented) so
something to be fixed.
Yeah, the meta regex is messy. One of those quick hacks to be replaced.
Thanks for the in-depth code review. Really helpful!
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=499
--
Sent by PEPr, the automatic proposal system at http://pear.php.net