Re: Re: [ANNOUNCEMENT] DB-1.7.13 (stable) Released.
| From: | Adam Harvey | Date: | Mon, 24 Sep 2007 04:20:22 +0000 |
| Subject: | Re: Re: [ANNOUNCEMENT] DB-1.7.13 (stable) Released. | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-48147@lists.php.net to get a copy of this message | ||
Quoting Justin Patrin <papercrane@gmail.com>:
This is exactly why I have always used =& in my PHP4 code. You can introduce subtle bugs if you don't use it, such as if, in the constructor, a reference to the object that is being instantiated is stored somewhere (such as in a sub-class). Various PEAR classes *will* break if code is changed to use = rather than =&.I don't mind reversing the changeset (you know, if I can figure out how to get CVS to _do_ that; that's reason #59394 why I prefer Subversion right there) and pushing out 1.7.14 if everyone thinks it's a bad idea, but give me some credit here: I did do an unusually thorough round of testing on PHP4 after making that change for precisely the reasons noted throughout this thread, and as far as I can tell, it hasn't caused a problem for DB. Adam -- Adam Harvey PEAR Profile: <http://pear.php.net/user/aharvey> Blog: <http://xn--9bi.net/>