Re: Request to be added to PHP_LexerGenerator (and probably PHP_ParserGenerator)

On 2007 09 29 08:50, Alan Langford wrote:

On 2007 09 20 23:39, Greg Beaver wrote:

Alan Langford wrote:

I have found and fixed a bug in this package, and another person has attached a few promising patches to bugs. I have also added processing instructions to flag regular expressions with the case-insensitive and Unicode flags. This makes case-less languages such as SQL much easier to handle. I'd like to get all of these changes (if the patches look good) into the trunk.

Hi Alan, Sounds good to me, please ask PEAR Group for karma to pear/PHP_LexerGenerator. I only ask that if your patch is at all complex, please open a bug report prior to committing so that I can review it. Small patches, such as many of the reports by joror, can be committed without review if you verify they work. I would love to have help with writing tests for the package, and if you feel up to the challenge, please take that on as well. Thanks, Greg

Greg: I have a large patch ready for review that merges joror's changes and mine, and adds the beginnings of a decent unit test suite. I opened bug #12144 for this, but the bug system won't let me add a patch, even though it has a .txt extension. (I get "insufficient privileges") So I've posted it here: http://dev.abivia.com/LexerGenerator-2007-09-29.txt Note that the unit test stuff is working well, but I haven't gotten to writing tests for the original changes yet! That's next.

This is now an even larger patch, available as http://dev.abivia.com/LexerGenerator-2007-10-01.txt This patch has tests to verify the changes made by joror and myself. The parsers have been regenerated using the new lexer, and all test cases and example files have also been updated. The changes to accept comments in .plex files, and my extensions to them (i.e. comments in the declaration section), are a bit of a kludge, since the lexer simply eats the comments rather than passing them back for the parser to handle in a proper grammar. Doing it right should be marked as a TODO somewhere. Everything passes unit testing. Given that this passes your review I consider this ready for commit. I've updated the package version to 0.4.0 because of some small changes to the API.