Re: QA: Package coding standards check
| From: | Chuck Burgess | Date: | Mon, 22 Oct 2007 13:05:51 +0000 |
| Subject: | Re: QA: Package coding standards check | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-48292@lists.php.net to get a copy of this message | ||
On 10/22/07, Igor Feghali <igor.feghali@gmail.com> wrote:
>
> <?php
> $result = $this->dumpSequence(
> $database_definition['sequences'][$sequence],
> $sequence, $eol, $dump
> );
> ?>
>
> gives me the errors:
> error 458 Space after opening parenthesis of function call
> prohibited
> error 461 Space before closing parenthesis of function call
> prohibited
>
> I can't keep the lines behind the 85 character limit if I am not allowed
> to break the functions arguments.
>
I've dealt with blocks like that in this manner:
<?php
$result = $this->dumpSequence($database_definition['sequences'][$sequence],
$sequence, $eol, $dump);
?>
The combination of "85-char line limit", "no space after opening paren", and
"no space after closing paren" make it difficult to easily modify long lines
like that. Add to that the occurrences of array variables with ~30chars in
their name and ~10+chars in their multiple-level keys, and you have some
impossible-to-shorten lines while still indenting properly.
--
CRB
Let me introduce you to my very own DMCA-protected encryption key:
BC 1B 64 4A 8D DE 49 E8 C3 7D CC EE 1A AD EE F5
(compliments of Freedom-to-Tinker http://www.freedom-to-tinker.com/?p=1155)