Re: QA: Package coding standards check

whoever drew up the coding standards must've forgotten to put the "no space except for newlines" clause in there somewhere. i prefer igor's method ;) Chuck Burgess wrote:

On 10/22/07, Igor Feghali <igor.feghali@gmail.com> wrote:

<?php $result = $this->dumpSequence(

    $database_definition['sequences'][$sequence],
    $sequence, $eol, $dump

); ?> gives me the errors:

error   458     Space after opening parenthesis of function call

prohibited

error   461     Space before closing parenthesis of function call

prohibited I can't keep the lines behind the 85 character limit if I am not allowed to break the functions arguments.

I've dealt with blocks like that in this manner: <?php $result = $this->dumpSequence($database_definition['sequences'][$sequence],

    $sequence, $eol, $dump);

?> The combination of "85-char line limit", "no space after opening paren", and "no space after closing paren" make it difficult to easily modify long lines like that. Add to that the occurrences of array variables with ~30chars in their name and ~10+chars in their multiple-level keys, and you have some impossible-to-shorten lines while still indenting properly.

-- David Sanders Software Engineer Baseline Solutions Pty Ltd Suite 201 832 High St East Kew VIC 3102 Australia Phone: (03) 9249 9687 Fax: (03) 9249 9600 http://baselinesolutions.com.au ======================================================================== This e-mail contains privileged and confidential information. If you are not the intended recipient of this e-mail, you are hereby notified that you must not disseminate, copy or take any action in reliance on it. Please notify Baseline Solutions Pty Ltd via e-mail (security@baselinesols.com) if you are not the intended addressee of this e-mail transmission. Any views or opinions presented in this message are solely those of the author. ========================================================================