Re: cvs: pear /DB_Table package2.xml /DB_Table/DB/Table Generator.php

From:	David Morse	Date:	Tue, 11 Dec 2007 20:11:01 +0000
Subject:	Re: cvs: pear /DB_Table package2.xml /DB_Table/DB/Table Generator.php
References:	1 2 3	Groups:	php.pear.dev
Request:	Send a blank email to pear-dev+get-48752@lists.php.net to get a copy of this message

Hi Alan - Sorry about that. I did indeed read the DataObject generator code as a starting point for writing a generator for DB_Table, and copied some chunks of code directly. Looking at it again, it appears that I copied a large switch statement that you had written to convert a variety of RDBMS specific data type names to more generic data types, as well as several blocks that dealt with complications involving schemas in postgres, and I'm not sure what else. It was a stupid, and rude, oversight for me not to say this explicitly in the header. I'll add an appropriate comment. Regarding the licenses, I must admit I don't understand the issues. I thought the point of open source licenses was, in part, to protect this sort of borrowing/stealing of other open source code (with proper acknowledgement of others' contributions, which I failed to provide). Simple decency aside, if anyone understands the legal side of this better, I'd be curious to read what you say. Again, sorry Alan. -David

Hi Alan, Alan Knowles wrote:
It might be polite to add in the headers of DB/Table/Generator.php "Some of this code is originally from DB/DataObject/Generator.php.. by ...." And I've no idea PHP licensed code can be be changed to LGPL..... without author's/ contributors agreement...
This part of DB_Table was written by David Morse who should be able to tell you which parts of the DB_Table generator were inspired (or maybe copied) from the DBDO generator. Adding a suitable comment in the comment blocks of the generator is no problem, as long as the whole code can stay in its current form from a license point of view. Maybe somebody with more OS license's knowledge can comment on this? Regards, Mark

-- !-------------------------------------------------------------------! ! David Morse email: morse@cems.umn.edu ! ! Dept of Chem Eng & Mat Sci phone: (612)625-0167 ! ! University of Minnesota ! ! Minneapolis, MN 55455 ! !-------------------------------------------------------------------!