[PEPr] Comment on File Formats::File_CAB

Philippe Jausions (http://pear.php.net/user/jausions) has commented on the proposal for File Formats::File_CAB. Comment: __construct() is checking for $this->command when on UNIX but this doesn't allow the user to actually change the path before creating an instance, therefore treating the path as a constant from the user's point of view. To resolve that, either add an argument to the constructor or use static class properties. I'd rather see a unique public property for the path to the executable, and have default private values for Windows and Unix, this way the user only has to deal with one setting. Since the class is already checking if it runs on Windows of Unix there's no need to ask the user to set 2 different path properties. Some shell escaping of file names and arguments are missing. Some of the docblock tags are not in the right order (and some of the @param declarations is jumbled too) See the PEAR CS docblock example for reference. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=525 -- Sent by PEPr, the automatic proposal system at http://pear.php.net