[PEPr] Comment on HTML::HTML_Form_Error
| From: | David Sanders | Date: | Mon, 03 Mar 2008 00:14:48 +0000 |
| Subject: | [PEPr] Comment on HTML::HTML_Form_Error | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49231@lists.php.net to get a copy of this message | ||
David Sanders (http://pear.php.net/user/shangxiao) has commented on the proposal for
HTML::HTML_Form_Error.
Comment:
I'll be honest here, I don't think this code warrants a PEAR package...
but here are a couple of pointers for future proposals from you:
- All the methods and properties are static. You might want to consider
making a singleton instead, not strictly necessary but some argue that this
is better for object-oriented design.
- defines() should be replaced with class constants as defined by the PEAR
coding standard
- The package should define its own exception extending PEAR_Exception and
throwing this instead of just die()ing in setLanguage()
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=534
--
Sent by PEPr, the automatic proposal system at http://pear.php.net