[PEPr] Comment on HTML::HTML_Form_Error

Philippe Jausions (http://pear.php.net/user/jausions) has commented on the proposal for HTML::HTML_Form_Error. Comment: Hi Jacopo, I'm not trying to shoo you away from submitting packages for review, because I think the more you try the more you'll learn in the process. That being said this proposal is not up to par. For instance, you're using eval() (again) as in your other proposal. Also, this is not really related to Form per se, as the package evaluates any data. As David pointed out, "die" and "exit" are rather unwelcomed in reusable library code, even though you added options to control that behavior. The Language files are ill-conceived as they don't provide much control to the end user as they are not easily changed. Now, if you could come up with a valid use-case for some kind of controller that checks something, and then do something based on the result, that might be a bt more useful, even though it would be just a little more than just if / then blocks that you could pass around (provided you switch from abstract to instantiated classes.) Alos, be aware that every PEAR packages should run without any notices when rn with E_ALL. The example ou puut with the $_POST variables would not promote good coding style., when empty() or isset() should be called first. Now, I hope I'm not discouraging you to keep on coding for PEAR ;-) Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=534 -- Sent by PEPr, the automatic proposal system at http://pear.php.net