[PEPr] Comment on Authentication::Auth_MicroID
| From: | Philippe Jausions | Date: | Fri, 14 Mar 2008 01:36:38 +0000 |
| Subject: | [PEPr] Comment on Authentication::Auth_MicroID | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49421@lists.php.net to get a copy of this message | ||
Philippe Jausions (http://pear.php.net/user/jausions) has commented on the proposal for
Authentication::Auth_MicroID.
Comment:
Seems to be doing its thing.
Couple of remarks:
* In verify() use explode() instead of split()
* In the beginning of generate() you are mixing double " and single
quotes '
* Add doblock for the constant declaration
* It would seem cleaner to use defined() + constant() instead of just
@constant()
* In generate() I would throw an exception if $identity and/or $service
are not well-formed URIs
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=542
--
Sent by PEPr, the automatic proposal system at http://pear.php.net