[PEPr] Comment on Authentication::Auth_MicroID
| From: | Michael Gauthier | Date: | Fri, 14 Mar 2008 01:53:07 +0000 |
| Subject: | [PEPr] Comment on Authentication::Auth_MicroID | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49422@lists.php.net to get a copy of this message | ||
Michael Gauthier (http://pear.php.net/user/gauthierm) has commented on the proposal for
Authentication::Auth_MicroID.
Comment:
I second Philippe's comments.
You should make the exception class name more specific like
Auth_MircoID_BadAlgorithmException or
Auth_MircoID_AlgorithmNotFoundException.
Unit tests would be nice and not too difficult since it is such a small
class.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=542
--
Sent by PEPr, the automatic proposal system at http://pear.php.net