[PEPr] +1 for Testing::Testing_DocTest
| From: | Philippe Jausions | Date: | Thu, 20 Mar 2008 15:37:15 +0000 |
| Subject: | [PEPr] +1 for Testing::Testing_DocTest | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49472@lists.php.net to get a copy of this message | ||
Philippe Jausions (http://pear.php.net/user/jausions) has voted +1 on the proposal for
Testing::Testing_DocTest.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=537
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=537&handle=jausions
Comment:
- To be able to enforce the Config::singleton() you may consider creating
a protected __construct()
- Make sure you run PHP_CodeSniffer. I noticed a couple of minor issues,
such as missing spaces around => in foreach loops, or around = for default
values of method's arguments
- Where is the fclose() matching the fopen() call in
Outputter_Default::__construct() ?
- the "else if ... self::KW_DOCTEST_* " blocks of code in
Parser_Default::parse() might be cleaner (and faster) with a switch {}
block instead. (same for Parser_Default::_handleLineContinuation())
--
Sent by PEPr, the automatic proposal system at http://pear.php.net