Re: [PEPr] +1 for Testing::Testing_DocTest

Hi Philippe,

- To be able to enforce the Config::singleton() you may consider creating a protected __construct()

Good suggestion.

- Make sure you run PHP_CodeSniffer. I noticed a couple of minor issues, such as missing spaces around => in foreach loops, or around = for default values of method's arguments

Oh, are you sure ? On my machine: $ phpcs /usr/share/php/Testing gives zero warning, zero errors... "missing spaces around => in foreach loops, or around = for default arguments" is a PEAR CS requirement ? if so PHP_CodeSniffer do not report it on my machine...

- Where is the fclose() matching the fopen() call in Outputter_Default::__construct() ?

Yeah, I'll put the fclose() in the destructor.

- the "else if ... self::KW_DOCTEST_* " blocks of code in Parser_Default::parse() might be cleaner (and faster) with a switch {} block instead. (same for Parser_Default::_handleLineContinuation())

Agreed, but the whole thing (parser/tokenizer) is going to be refactored soon, so I'll leave it as is atm. Thanks for your comments. David.