[PEPr] Comment on Networking::Net_Gearman
| From: | Philippe Jausions | Date: | Sat, 12 Apr 2008 13:30:49 +0000 |
| Subject: | [PEPr] Comment on Networking::Net_Gearman | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49762@lists.php.net to get a copy of this message | ||
Philippe Jausions (http://pear.php.net/user/jausions) has commented on the proposal for
Networking::Net_Gearman.
Comment:
There are some discrepancies between the doclock @return and what is
actually returned from some of the methods, for instance
Net_Gearman_Connection::send(), Net_Gearman_Connection::connect() and
Net_Gearman_Client::__call()
I wonder what are the benefits to have Net_Gearman_Connection as an
abstract class. It could make things difficult for people wanting to use
mock object during testing.
Otherwise, looks very clean (as usual :-)
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=548
--
Sent by PEPr, the automatic proposal system at http://pear.php.net