[PEPr] +1 for Networking::Net_Gearman

Michael Gauthier (http://pear.php.net/user/gauthierm) has voted +1 on the proposal for Networking::Net_Gearman. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=548 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=548&handle=gauthierm This vote is conditional. The condition is: in Net_Gearman_Connection - $multiByteSupport should be private static instead of public - documentation of connect() says it populates the static $magic array but it actually happens in immediately executable code after the class definition. Could the initialization of the $magic array happen lazily like the static $multiByteSupport member variable? That way both the commands and magic properties could also be private. Initilization could be done with a private static method and reused in the other Connection methods. - documentation of magic refers to non-existent constructor - connect() method refers to non-existent $socket member variable - connect() documentation says it returns void but it really returns a socket resource - this may not be applicable to Gearman but you should be able to specify the port in the connect() method - @throws documentation should say why an exception would be thrown -- Sent by PEPr, the automatic proposal system at http://pear.php.net