[PEPr] Comment on File Formats::File_Sitemap

From: Date: Sat, 26 Apr 2008 16:42:04 +0000
Subject: [PEPr] Comment on File Formats::File_Sitemap
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-49912@lists.php.net to get a copy of this message
Philippe Jausions (http://pear.php.net/user/jausions) has commented on the proposal for File Formats::File_Sitemap. Comment: Quick review: - The @license is not in sync with the license blurb in file docblock. - Don't use PHP4-style constructors, use PHP5's __construct() instead - You have some typos in the parseURL method in the $url array. - I'm not really seeing the need to double query the notify URL couldn't errors be handled in one pass only? - the test() method @return void while it actually @return boolean - There are trailing empty lines after the last closing ?> in the files Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=555 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#49912) next »