[PEPr] +1 for File Formats::File_Sitemap

Michael Gauthier (http://pear.php.net/user/gauthierm) has voted +1 on the proposal for File Formats::File_Sitemap. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=555 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=555&handle=gauthierm Comment: What till said. Additionally: 1. Specify public scope for methods File_SiteMap::__construct() and File_SiteMap::add() 2. Use single or double quotes consistently. I prefer single quotes unless escaping is required. 3. Use class constants instead of define statements for error codes. For example, use 'const ERROR_FOO = 1' in File_SiteMap so your error code is File_SiteMap::ERROR_FOO instead of FILE_SITEMAP_FOO_ERROR. 4. For mixed type arguments, you should specify what types are accepted in the parameter description. File_SiteMap_Index::add() comes to mind. -- Sent by PEPr, the automatic proposal system at http://pear.php.net