[PEPr] Comment on Web Services::Services_Crowd

From: Date: Tue, 08 Jul 2008 13:27:45 +0000
Subject: [PEPr] Comment on Web Services::Services_Crowd
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-50360@lists.php.net to get a copy of this message
David Jean Louis (http://pear.php.net/user/izi) has commented on the proposal for Web Services::Services_Crowd. Comment: Hey Luca, Never heard of Crowd so I can't "judge" the package, here are some general remarks nonetheless: * I would not make the 3 class variables private, it makes sub-classing difficult, "protected" seems better to me; * I think some repeated parts of the code (especially in the 3 last methods) could be put in common (using a protected method or using the __call() magic method...). Looks good and well documented and tested otherwise. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=565 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#50360) next »