[PEPr] +1 for Web Services::Services_Atlassian_Crowd
| From: | Till Klampaeckel | Date: | Wed, 20 Aug 2008 02:03:50 +0000 |
| Subject: | [PEPr] +1 for Web Services::Services_Atlassian_Crowd | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-50577@lists.php.net to get a copy of this message | ||
Till Klampaeckel (http://pear.php.net/user/till) has voted +1 on the proposal for Web
Services::Services_Atlassian_Crowd.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=565
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=565&handle=till
Comment:
Nothing major to add, except for those suggestions:
1) Document __call() with @method
2) Maybe double check the options passed into the class, if you require a
url/endpoint, it wouldn't hurt to check if it's set before SOAP throws an
error (imho). My point extends to 'app_credential', etc. as well.
I also like the idea of a config object which you can ask for info,
Services_Atlassian_Crowd_Config::getServiceUrl(), etc.. But that might be
too much. ;)
3) I think @access tags are not necessary in PHP5.
Good work! :)
--
Sent by PEPr, the automatic proposal system at http://pear.php.net