[PEPr] Comment on Web Services::OAuth

Till Klampaeckel (http://pear.php.net/user/till) has commented on the proposal for Web Services::OAuth. Comment: Hey, I saw your updates, but the code I recently checked out (r38) from Google Code still had Net_URL in it (vs. you talking about Net_URL2), or is this my misunderstanding? Also, speaking of PHP4 vs 5 - I was wondering if you'd like to do a cURL-based driver for all HTTP instead of HTTP_Request, I'd contribute code also if you are too busy. Just let me know. Then I was wondering if you'd provide a build in way to override OAuth_Consumer::redirect() (I don't like the "header()-call" in there, I'd rather provide a screen to the user stating, 'You are redirect because of ...'.) or would you rather prefer people to extend your code and override there? Aside, some of your code could use some inline documentations. At the same time I also want to add that I didn't have too much trouble finding my way around. Great work. And I bet you are working on that before you call for votes. ;) Last but not least, a bug report: In OAuth_Consumer::setRequestScheme() your example dies. "'e' is an unsupported request scheme" I couldn't figure out at first why the in_array() with the constants did not work. (Besides, maybe make the array() 'static'?) When you comment it out, it moves on but the same issue is brought up by OAuth_Http_RequestToken::_attemptRequest(). Due to it being unable to match the scheme, the $httpClient var is null. The reason why it dies is because your example does "new OAuth_Consumer($consumer_key, $consumer_key_secret, $options);", while the definition of the __construct() states a single parameter "$options". I figured out that if I included the keys 'consumerKey' and 'consumerSecret' in the $options it works. To cut a long story short, once that was fixed it also worked on Pownce. :) If you do any updates, let me know. I'd try it out right away. Cheers, Till Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=512 -- Sent by PEPr, the automatic proposal system at http://pear.php.net