[PEPr] Comment on Web Services::OAuth

Joe Stump (http://pear.php.net/user/jstump) has commented on the proposal for Web Services::OAuth. Comment: 1. I've noticed that none of the code inside of (http://oauth-for-php.googlecode.com/svn/trunk/library/OAuth.php) is documented with phpDocumentor. 2. In setOptions() (http://oauth-for-php.googlecode.com/svn/trunk/library/OAuth/Client.php) you have a bunch of case statements, which means that I can't add my own options in a child class. I'd recommend doing $func = 'set' . ucfirst($key) and then if (method_exists($this, $func)) { $this->$func($value); } 3. Some of the spacing doesn't conform to the PEAR CS. Check out PHP_CodeSniffer's CLI utility phpcs for help with that. 4. Are you looking for help with this package? We're going to be implementing OAuth soon at Digg and could probably help with a bunch of this stuff. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=512 -- Sent by PEPr, the automatic proposal system at http://pear.php.net