[PEPr] Comment on Web Services::Services_GeoNames

From: Date: Thu, 04 Sep 2008 13:49:34 +0000
Subject: [PEPr] Comment on Web Services::Services_GeoNames
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-50713@lists.php.net to get a copy of this message
Chuck Burgess (http://pear.php.net/user/ashnazg) has commented on the proposal for Web Services::Services_GeoNames. Comment: Usage examples work perfectly. PHPT tests all work, though they take a long time to run since they do run against the live service. I wonder if PHPT format allow for mock objects, so that we could split some tests into local unit tests while still allowing for live system/integration tests like the current ones. Code and docblocks look good. I'd add some notes (even if marked as @internal) to the __call() docblock to highlight the usage of the "@" error suppression, so that anyone trying to troubleshoot will be advised that such suppression is occurring. Nice compact codebase wrapper for such a wide-method service... kudos ;) Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=550 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#50713) next »