Re: [PEPr] +1 for Web Services::Services_GeoNames
| From: | David Jean Louis | Date: | Wed, 10 Dec 2008 11:56:55 +0000 |
| Subject: | Re: [PEPr] +1 for Web Services::Services_GeoNames | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-51251@lists.php.net to get a copy of this message | ||
Christian Weiske a écrit :
Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the proposal for Web Services::Services_GeoNames. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=550 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=550&handle=cweiske Comment: Nicely small and clean code. I'd like to see @method tags in the class docblock since you use __call.I thought about adding the @method tags but imho it would be just duplicating the geonames documentation, and it would be harder to maintain/keep sync with their API, that's why I just put an @link tag pointing to the official documentation. see: http://www.geonames.org/export/ws-overview.html