Re: [PEPr] +1 for Logging::Log_FirePHP

Hello Michael,

Michael Gauthier (http://pear.php.net/user/gauthierm) has voted +1 on the proposal for Logging::Log_FirePHP. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=578 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=578&handle=gauthierm This vote is conditional. The condition is: Well this is one of the coolest things I've seen today. I appreciate the amount of work you did to document the package. My vote is conditional, as the package is not packaged properly. Files are not following the file name conventions and no package.xml exists. If you have questions about making this into a PEAR package, #pear or pear-dev@ can direct you.

I don't need support to build a package with PEAR_PackageFileManager (and even from scratch), perharps because I've worked in past as a co-leader in its development. You should have in mind what I've wrote in proposal introduction "This proposal is not supposed to be a new package but a driver for existing PEAR::Log package" So it could be included and packaged in next version. No new package or sub-package !

The ZIP file you provided is also corrupt -- I can only view and extract the firephp.php file. Additionally, this package depends on a non-PEAR package and I'm not sure what PEAR's stance is on that.

Even if Coding Standard have been changed since, PEAR::Log is an old package and probably not follow all rules established now with new PEAR CS (especially for new PHP5 development). This FirePHP driver run only with PHP5 but was written as a PHP4 driver to be supported and integrated easily into PEAR::Log framework. Hope I've answered to all your questions