Re: [PEPr] +1 for HTML::PHPTAL

Kornel, 2009/4/28 Kornel Lesiński <kornel@aardvarkmedia.co.uk>: > On 27-04-2009 at 19:48:46 Michael Gauthier <mike@silverorange.com> wrote: > (...) >>> OK. The only one left now is PHPTAL_VERSION, which I presume is OK, as >>> other PEAR packages are using such defines. >>> >> New PEAR packages should not use any define() constants. Any packages >> using such constants are from the PHP4 era. > > PEAR itself is PHP4 software and 4 out of 5 most popular PEAR downloads > violate this rule. > > Which packages should I take as an example then? Michael stated the rule. Examples include: Services_Amazon_S3 HTTP_Request2 Services_Twitter Log_FirePHP File_CVS_Get In general, scroll down to finished (and check accepted packages): http://pear.php.net/pepr/ PEAR has been around for ages. Of course there is still PHP4 code, but *new* packages must adhere to those new rules. >> Classes and interfaces should still be one to a file. There is an >> exception to the rule for Exception classes, which may go in a single >> file. Keep in mind that this rule is changing for PEAR2 where the >> class-per-file will be stricter. > > I've split RepeatController.php, but I'm not convinced that splitting files > further would be helpful to anybody (some of them would have more PEAR > boilerplate than code). Honestly, I don't even know how to comment on that. ;-) (...) Till