Re: pyrus is ready for initial testing

On Fri, Jun 12, 2009 at 9:50 PM, Brett Bieber <brett.bieber@gmail.com>wrote: > On Fri, Jun 12, 2009 at 3:23 AM, Daniel > O'Connor<daniel.oconnor@gmail.com> wrote: > > If you mean: http://pear.php.net/bugs/bug.php?id=15887 I > > can try to have > a > > shot at it in the near term. That being said, if someone else beats me to > > the punch I won't complain! > > The odd thing is that some are fine. For example: > http://pear.php.net/rest/c/Event/packagesinfo.xml > > I looked at this yesterday and while the implementation isn't elegant, > I didn't see why it wouldn't work? Could it be that the code in > pearweb is functionally correct, each of the files just needs to be > re-generated? > Its kind of nasty right now. File A has <?xml foo ?> at the top of it, and File B does too. The category stuff generates by sticking B into A, and it accidentally includes too much detail - like double including <?xml ?> bits. The best solution would be to load files as XML instead of text, and use DOM to append one to the other, then re-save. What its doing now is basically that, but with str_replace to try and remove the <?xml tags, which fails sporadically.