Re: [PEPr] Comment on HTTP::HTTP_OAuth
| From: | Jeff Hodsdon | Date: | Wed, 29 Jul 2009 17:42:31 +0000 |
| Subject: | Re: [PEPr] Comment on HTTP::HTTP_OAuth | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-52528@lists.php.net to get a copy of this message | ||
Hey Till, thanks for giving this package a look!
> 1) Would you mind abstracting the HTTP-part and also allow people to use
> HTTP_Request2? With HTTP_Request2 there are curl and socket, extensions 99%
> of all PHP installs offer. With pecl_http the adoption of your package
> could be considerably harder.
I used pecl_http for the HttpMessage class and support for responses. The
HTTP_OAuth_Consumer_Response, HTTP_OAuth_Provider_Request, and
HTTP_OAuth_Provider_Response all decorate HttpMessage. I use
HttpMessage::fromEnv() as a default way of constructing a response,
therefore it will grab the existing headers set, body, etc. HTTP_Request2
does not have much support for responses. There is a lot of header parsing
and setting in OAuth requests and I prefer not using header() directly.
2) How would you compare HTTP_Oauth to pecl/Oauth? [Just as a disclaimer,
> I'm very much in favor of a pure PHP implementation vs. just a pecl ext,
> this is more or less because I'm curios.]
I originally set out to create an OAuth provider package but ended up adding
consumer support because I already had a lot of code that could be used to
create it. The pecl oauth extension does not have any provider support.
Additionally I wanted to test my provider code and therefore needed to see
more debug information from OAuth requests.
Thanks!
-jeff