[PEPr] +1 for HTTP::HTTP_OAuth

Till Klampaeckel (http://pear.php.net/user/till) has voted +1 on the proposal for HTTP::HTTP_OAuth. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=607 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=607&handle=till Comment: Generally works for me, though I got a couple things/suggestions: a) The tests could be improved. E.g. if Log is optional, it should skip the test or disregard it silently. Warning: require_once(Log.php): failed to open stream: No such file or directory in /usr/share/php/tests/HTTP_OAuth/tests/HTTP/OAuthTest.php on line 26 Call Stack: 0.0000 119688 1. {main}() /usr/share/php/tests/HTTP_OAuth/tests/AllTests.php:0 0.0000 162200 2. require_once('/usr/share/php/tests/HTTP_OAuth/tests/HTTP/OAuthTest.php') /usr/share/php/tests/HTTP_OAuth/tests/AllTests.php:27 Fatal error: require_once(): Failed opening required 'Log.php' (include_path='/usr/share/php/tests/HTTP_OAuth/tests:/usr/share/php/tests/HTTP_OAuth:.:/usr/share/php:/usr/share/pear') in /usr/share/php/tests/HTTP_OAuth/tests/HTTP/OAuthTest.php on line 26 Call Stack: 0.0000 119688 1. {main}() /usr/share/php/tests/HTTP_OAuth/tests/AllTests.php:0 0.0000 162200 2. require_once('/usr/share/php/tests/HTTP_OAuth/tests/HTTP/OAuthTest.php') /usr/share/php/tests/HTTP_OAuth/tests/AllTests.php:27 I see there are a lot more tests than I'm able to run. For me a single test runs as of now. b) Here's a patch to package.xml -- it removes HTTP_OAuth-0.0.1.tgz. diff --git a/HTTP_OAuth-0.0.2.tgz b/HTTP_OAuth-0.0.2.tgz index 74f8089..af8a738 100644 Binary files a/HTTP_OAuth-0.0.2.tgz and b/HTTP_OAuth-0.0.2.tgz differ diff --git a/package.xml b/package.xml index 92c3107..10d2797 100644 --- a/package.xml +++ b/package.xml @@ -78,7 +78,6 @@ Initial release <file baseinstalldir="/" md5sum="c84af90f5a080ae833fdf6ebb29d5f52" name="tests/HTTP/OAuth/Signature/PLAINTEXTTest.php" rol <file baseinstalldir="/" md5sum="1321ef2eb53b6da6ef0f5505844ff4c1" name="tests/HTTP/OAuth/Signature/HMAC/SHA1Test.php" rol <file baseinstalldir="/" md5sum="b967a7e1d433333d442a87918e415e56" name="tests/HTTP/OAuth/Signature/RSA/SHA1Test.php" role - <file baseinstalldir="/" md5sum="c41ac43aced230c1e54a5132189f0129" name="HTTP_OAuth-0.0.1.tgz" role="data" /> <file baseinstalldir="/" md5sum="d41d8cd98f00b204e9800998ecf8427e" name="README" role="data" /> </dir> </contents> c) Generally, some docs wouldn't hurt that translate your various examples into docbook. That's not mandatory though for this to get accepted. I'm just adding it here. Aside from that. You provided a very, very comprehensive example. I'm thinking this will jump start a lot of people right away. d) You probably saw it coming, please run phpcs. :) There are (really) minor issues. Great job! I'm looking forward to this package.