Re: Re: Spreadsheet_Excel_Writer - patch for bug #2405 applied to svn

Hi Franck, > I give the two anothers patchs : > http://pear.php.net/bugs/bug.php?id=2261 > http://pear.php.net/bugs/bug.php?id=8701 > http://pear.php.net/bugs/bug.php?id=14932 I applied the patch for bug #2261 and committed it. The two other patches had tabs instead of spaces in them. This is not allowed according to our coding standards: > http://pear.php.net/manual/en/standards.php Have you heard of PHP_CodeSniffer (phpcs)? It's the tool that tells us if our code conforms to the PEAR Coding Standards. The SEW (Spreadsheet_Excel_Writer) code probably totally fails, but when patching it, the error/warning count after applying the patch should be lower or equal to the count before :) Please fix the patches, and I'll apply them. > Finally, bugs are automatically closed after application of the patch > in the SVN. No, unfortunately not. Our bug tracker does not support that yet - but it's planned in my head :) -- Regards/Mit freundlichen Grüßen Christian Weiske -= Geeking around in the name of science since 1982 =-

Attachment: [application/pgp-signature] signature.asc