Re: Spreadsheet_Excel_Writer - patch for bug #2405 applied to svn
| From: | LEFEVRE Franck | Date: | Fri, 14 Aug 2009 10:44:53 +0000 |
| Subject: | Re: Spreadsheet_Excel_Writer - patch for bug #2405 applied to svn | ||
| References: | 1 2 3 4 5 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-52633@lists.php.net to get a copy of this message | ||
Christian Weiske <cweiske <at> cweiske.de> writes:
>
> Hi Franck,
>
> > No, I just checkout the SVN (after some searchs : is the documentation up to
> > date ?) and modify for adding examples.
> >
> > Yes, my problem of tabs. I correct the patch with the problem.
>
> I just saw you updated the documentation patches. I did not just mean
whitespace; I mean all the other things
> like the for loop - please stick to the pear CS.
> http://pear.php.net/bugs/bug.php?id=5403
>
Hi Christian, i read again all the CS.
I modified my loop for.
I don't think after reading again my code, no others modifications.
Bye