[PEPr] Comment on Images::Image_Diff
| From: | Daniel O'Connor | Date: | Fri, 04 Sep 2009 05:57:56 +0000 |
| Subject: | [PEPr] Comment on Images::Image_Diff | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-52762@lists.php.net to get a copy of this message | ||
Is there any compelling reason to make these static methods?
Being static means I can't mock them out, and makes them more like
namespaced functions than an Image_Diffing object.
Ie:
Image_Diff::nearlySame()
could easily be
$diff = new Image_Diff();
$diff->nearlySame();
while having none of the drawbacks of statics
(http://misko.hevery.com/code-reviewers-guide/flaw-brittle-global-state-singletons/)
--
http://pear.php.net/pepr/pepr-proposal-show.php?id=611