[PEPr] Comment on Images::Image_Diff
| From: | Michael Gauthier | Date: | Sun, 17 Jan 2010 05:10:40 +0000 |
| Subject: | [PEPr] Comment on Images::Image_Diff | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-53221@lists.php.net to get a copy of this message | ||
Looks good. A few comments:
1.) Like Daniel mentioned, making all the methods static makes it harder
to unit test the class.
2.) You don't need to assign copyright to the PHP Group. It can be
copyrighted to you or the company you work for.
3.) It would be nice to see some sort of high-level documentation in the
source about how exactly the images are being compared. Is it just
comparing all pixels to see if they are the same color? How is "near"
defined, etc.
--
http://pear.php.net/pepr/pepr-proposal-show.php?id=611