PHP_CodeSniffer 1.2
| From: | Bill Shupp | Date: | Thu, 05 Nov 2009 08:27:45 +0000 |
| Subject: | PHP_CodeSniffer 1.2 | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-53027@lists.php.net to get a copy of this message | ||
It appears that phpcs 1.2 has different handling of multi-line method definitions. With 1.1, the following would pass without warnings:
public function directRequest($url,
OpenID_Message $message,
array $options = array())
{
}
In the above, everything is lined up on the left with the first argument, $url. However, with 1.2, this is what I have to do to eliminate warnings:
public function directRequest($url,
OpenID_Message $message, array $options = array()) {
....
}
This has the second line of arguments lined up with the "public" keyword, and the opening curly brace on the same line. This looks like a bug - can anyone confirm? If not, then I take issue this this representing the PEAR standard.
Cheers,
Bill Shupp