Re: PHP_CodeSniffer 1.2

On Nov 5, 2009, at 12:53 AM, Christian Weiske wrote:

Hi Bill, The correct way is: public function directRequest($url, OpenID_Message $message, array $options = array() ) { .... } see: http://pear.php.net/manual/en/standards.funcdef.php "Split function definitions onto several lines"

I've never noticed this, and don't like it. I think it's much harder to read this way than splitting them on one argument per line. And now, after I've spent lots of time getting my code to pass phpcs 1.1 cleanly in my OpenID package, and now with the upgrade to 1.2, I'm left with 475 warnings or errors to deal with. Bill