[PEPr] Comment on HTML::HTML_Template

From: Date: Sun, 31 Jan 2010 23:04:26 +0000
Subject: [PEPr] Comment on HTML::HTML_Template
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-53244@lists.php.net to get a copy of this message
a) Naming It's been discussed before, If you could provide an API, and write the code to unify all the existing template engines in PEAR etc. then this would be a suitable name, otherwise please pick a name 'HTML_Template_Jacopo' or similar. (there was considerable interest in doing this a few years ago, but it never saw the light of day... as unfortuntaly it's not a pretty problem to solve.) b) Escaping output. Did not see that the engine was doing this.. - bit of a security hole, c) Include all - why include the compiler etc. when you may have already compiled the template. d) Constants - please use PHP5 constants, rather than poluting the global namespace. Last of all: Think about why this is an improvement on the current offerings in PEAR, why you did not contribute to them rather than create a new one. -- http://pear.php.net/pepr/pepr-proposal-show.php?id=626

« previous php.pear.dev (#53244) next »